[CMake] Fix vetoes for tutorials if numpy or xrootd are not available #20659
Conversation
Test Results 21 files 21 suites 3d 17h 23m 10s ⏱️ Results for commit 4fba06b. ♻️ This comment has been updated with latest results. |
This doesn't help the user, and also confuses the CI when testing, because tutorials can apparently succeed even if they do nothing.
Follows up on 45bef34, adding a veto if NumPy is not found. Also, move vetoes for tutorials when xrootd is not available to the right place.
guitargeek
force-pushed
the
tutorials_veto
branch
from
aedec41 to
4fba06b
Compare
vepadulano
left a comment
vepadulano
left a comment
There was a problem hiding this comment.
LGTM thanks! Please merge once CI is green.
|
I think this accidentally broke testing of the Python wheels (that were probably relying on successfully exiting even if the input file is missing, which btw was not mentioned anywhere in the PR!): https://github.com/root-project/root/actions/runs/20119030998 FYI @siliataider |
|
@hahnjo Thanks for checking so quickly! I am glad to see the action is working as intended! |
Well the wheels tests were not relying on successfully exiting even if the input file is missing, they were relying on successfully exiting if no error is raised, and since the tutorial was detecting a missing file and still exiting with 0, the wheels tests cannot detect that a file is missing in this case and mark it failed |
4 participants
Follows up on 45bef34, adding a veto if NumPy is not found. Also, move vetoes for tutorials when xrootd is not available to the right place.